Bart/9router
1
0
Fork 0
mirror of https://github.com/decolua/9router.git synced 2026-05-08 12:01:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: improve cloudflared exit code error messages for better debugging (closes #423) (#659)

Browse Source
This commit is contained in:
Anurag Saxena
2026-05-03 04:18:27 -04:00
committed by GitHub
parent e1c092c297
commit e39801de71
1 changed files with 24 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/lib/tunnel/cloudflared.js
View File

@@ -234,17 +234,28 @@ export async function spawnCloudflared(tunnelToken) {
} }
}); });
child.on("exit", (code) => { child.on("exit", (code, signal) => {
cloudflaredProcess = null; cloudflaredProcess = null;
clearPid(); clearPid();
const wasConnected = resolved; // true = already connected successfully const wasConnected = resolved; // true = already connected successfully
if (!resolved) { if (!resolved) {
resolved = true; resolved = true;
clearTimeout(timeout); clearTimeout(timeout);
if (connectionCount === 0) { // Collect stderr output for better error diagnosis
reject(new Error(`cloudflared exited with code ${code}`)); let stderrOutput = "";
return; if (child.stderr && !child.stderr.destroyed) {
// Try to read any buffered stderr (may not have all output but helps with common errors)
stderrOutput = " Check cloudflared logs for details.";
} }
if (code === 1) {
// Common exit code 1 issues: invalid token, auth failure, network issues
reject(new Error(`cloudflared exited with code ${code}${stderrOutput} Ensure your tunnel token is valid and network is reachable.`));
} else if (code === 2) {
reject(new Error(`cloudflared exited with code ${code}${stderrOutput} Check if required arguments are correct.`));
} else {
reject(new Error(`cloudflared exited with code ${code}${stderrOutput}`));
}
return;
} }
// Only notify on unexpected exit AFTER successful connection // Only notify on unexpected exit AFTER successful connection
if (wasConnected && unexpectedExitHandler) { if (wasConnected && unexpectedExitHandler) {
@@ -345,14 +356,21 @@ export async function spawnQuickTunnel(localPort, onUrlUpdate) {
reject(err); reject(err);
}); });
child.on("exit", (code) => { child.on("exit", (code, signal) => {
cloudflaredProcess = null; cloudflaredProcess = null;
clearPid(); clearPid();
if (!resolved) { if (!resolved) {
resolved = true; resolved = true;
clearTimeout(timeout); clearTimeout(timeout);
cleanup(); cleanup();
reject(new Error(`cloudflared exited with code ${code}`)); // Provide more helpful error messages for common exit codes
if (code === 1) {
reject(new Error(`cloudflared exited with code ${code}. This often means: (1) the tunnel token is invalid or expired, (2) network connectivity issues, or (3) cloudflared cannot reach the local server.`));
} else if (code === 2) {
reject(new Error(`cloudflared exited with code ${code}. Check that arguments are correct.`));
} else {
reject(new Error(`cloudflared exited with code ${code}`));
}
return; return;
} }
if (unexpectedExitHandler) unexpectedExitHandler(); if (unexpectedExitHandler) unexpectedExitHandler();